docs: Updated docs on testing Electron using WebdriverIO #39380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
documentation 📓
semver/patch
christian-bromann
force-pushed
the
christian-bromann-patch-1
branch
from
007cf4f
to
e5963b7
Compare
christian-bromann
changed the title
christian-bromann
force-pushed
the
christian-bromann-patch-1
branch
3 times, most recently
from
9eb98b4
to
19d08b3
Compare
codebytere
reviewed
Aug 8, 2023
There was a problem hiding this comment.
@christian-bromann - someone should be round to review this more thoroughly soon, but in the meantime lint is failing due to this issue:
docs/tutorial/automated-testing.md:43:69 MD049/emphasis-style Emphasis style should be consistent [Expected: asterisk; Actual: underscore]
checks should go green once that's addressed!
notes: Updated docs on testing Electron using WebdriverIO
christian-bromann
force-pushed
the
christian-bromann-patch-1
branch
from
19d08b3
to
a55d39d
Compare
erickzhao
reviewed
Aug 8, 2023
| chromedriver: { | ||
| logFileName: 'wdio-chromedriver.log' | ||
| }, | ||
| electronVersion: '23.1.0' |
There was a problem hiding this comment.
If we're reading the package.json, shouldn't this be derived from the project's devDependencies?
| // ... | ||
| } | ||
| ``` | ||
|
|
||
| The Electron service takes care of downloading the right Chromedriver version for you, updating | ||
| your capabilities to point to your Electron application as well as offers useful testing features |
There was a problem hiding this comment.
Suggested change
| your capabilities to point to your Electron application as well as offers useful testing features | |
| your [ChromeDriver capabilities](https://chromedriver.chromium.org/capabilities) to point to your Electron application as well as offers useful testing features |
We didn't do this in the previous version of the docs either, but I think it would be helpful to link to ChromeDriver's definition of what capabilities are.
github-actions
bot
added
the
target/27-x-y
|
Closing in favor of #40083 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Recommend users a better setup for testing Electron Applications with WebdriverIO.
Checklist
npm testpassesRelease Notes
Notes: Updated docs on testing Electron using WebdriverIO