-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use aks backed runners for linux builds #39403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
approved these changes
Aug 8, 2023
No Release Notes |
5 tasks
MarshallOfSound
added a commit
that referenced
this pull request
Sep 12, 2023
* build: test aks runner * build: stress test * build: use super-large nodes for publish jobs * build: try using aks for everything... * build: shared host not great * build: clean up * build: apparently tests dont run in kube infra? * build: do not change test size
@MarshallOfSound has manually backported this PR to "26-x-y", please check out #39835 |
MarshallOfSound
added a commit
that referenced
this pull request
Sep 12, 2023
* build: test aks runner * build: stress test * build: use super-large nodes for publish jobs * build: try using aks for everything... * build: shared host not great * build: clean up * build: apparently tests dont run in kube infra? * build: do not change test size
@MarshallOfSound has manually backported this PR to "25-x-y", please check out #39836 |
MarshallOfSound
added a commit
that referenced
this pull request
Sep 12, 2023
* build: test aks runner * build: stress test * build: use super-large nodes for publish jobs * build: try using aks for everything... * build: shared host not great * build: clean up * build: apparently tests dont run in kube infra? * build: do not change test size
@MarshallOfSound has manually backported this PR to "24-x-y", please check out #39837 |
MarshallOfSound
added a commit
that referenced
this pull request
Sep 12, 2023
* build: test aks runner * build: stress test * build: use super-large nodes for publish jobs * build: try using aks for everything... * build: shared host not great * build: clean up * build: apparently tests dont run in kube infra? * build: do not change test size
@MarshallOfSound has manually backported this PR to "22-x-y", please check out #39838 |
MarshallOfSound
added a commit
that referenced
this pull request
Sep 12, 2023
* build: use aks backed runners for linux builds (#39403) * build: test aks runner * build: stress test * build: use super-large nodes for publish jobs * build: try using aks for everything... * build: shared host not great * build: clean up * build: apparently tests dont run in kube infra? * build: do not change test size * ci: fixup known hosts for linux publish (#39437) * ci: fixup known hosts for linux publish * build: use 2023 known hosts * build: use rebuilt docker image * Revert "build: use rebuilt docker image" This reverts commit f9506a9. --------- Co-authored-by: Samuel Attard <marshallofsound@electronjs.org> --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
MarshallOfSound
added a commit
that referenced
this pull request
Sep 12, 2023
* build: use aks backed runners for linux builds (#39403) * build: test aks runner * build: stress test * build: use super-large nodes for publish jobs * build: try using aks for everything... * build: shared host not great * build: clean up * build: apparently tests dont run in kube infra? * build: do not change test size * ci: fixup known hosts for linux publish (#39437) * ci: fixup known hosts for linux publish * build: use 2023 known hosts * build: use rebuilt docker image * Revert "build: use rebuilt docker image" This reverts commit f9506a9. --------- Co-authored-by: Samuel Attard <marshallofsound@electronjs.org> --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
trop
bot
added
merged/25-x-y
PR was merged to the "25-x-y" branch.
and removed
in-flight/25-x-y
in-flight/22-x-y
labels
Sep 12, 2023
MarshallOfSound
added a commit
that referenced
this pull request
Sep 12, 2023
* build: use aks backed runners for linux builds (#39403) * build: test aks runner * build: stress test * build: use super-large nodes for publish jobs * build: try using aks for everything... * build: shared host not great * build: clean up * build: apparently tests dont run in kube infra? * build: do not change test size * ci: fixup known hosts for linux publish (#39437) * ci: fixup known hosts for linux publish * build: use 2023 known hosts * build: use rebuilt docker image * Revert "build: use rebuilt docker image" This reverts commit f9506a9. --------- Co-authored-by: Samuel Attard <marshallofsound@electronjs.org> --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
trop
bot
added
merged/22-x-y
PR was merged to the "22-x-y" branch.
and removed
in-flight/24-x-y
labels
Sep 12, 2023
MarshallOfSound
added a commit
that referenced
this pull request
Sep 12, 2023
* build: use aks backed runners for linux builds (#39403) * build: test aks runner * build: stress test * build: use super-large nodes for publish jobs * build: try using aks for everything... * build: shared host not great * build: clean up * build: apparently tests dont run in kube infra? * build: do not change test size * ci: fixup known hosts for linux publish (#39437) * ci: fixup known hosts for linux publish * build: use 2023 known hosts * build: use rebuilt docker image * Revert "build: use rebuilt docker image" This reverts commit f9506a9. --------- Co-authored-by: Samuel Attard <marshallofsound@electronjs.org> --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
win32ss
pushed a commit
to win32ss/supermium-electron
that referenced
this pull request
Sep 24, 2023
* build: test aks runner * build: stress test * build: use super-large nodes for publish jobs * build: try using aks for everything... * build: shared host not great * build: clean up * build: apparently tests dont run in kube infra? * build: do not change test size
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* build: test aks runner * build: stress test * build: use super-large nodes for publish jobs * build: try using aks for everything... * build: shared host not great * build: clean up * build: apparently tests dont run in kube infra? * build: do not change test size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged/22-x-y
PR was merged to the "22-x-y" branch.
merged/24-x-y
PR was merged to the "24-x-y" branch
merged/25-x-y
PR was merged to the "25-x-y" branch.
merged/26-x-y
PR was merged to the "26-x-y" branch.
no-backport
semver/none
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes nothing about the build environment, only the underlying build infrastructure. Linux jobs are still run inside the same docker containers but now those docker containers run inside an auto scaling kubernetes cluster. The plan per #wg-infra is to merge this and monitor for any perceived impact to build times and measure actual impact to CI infra costs. At any point this change can be reverted if it is causing issues.
Notes: none