Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose dummy module.exports to the sandboxed preload scripts #39484

Merged
merged 1 commit into from Aug 22, 2023
Merged

feat: expose dummy module.exports to the sandboxed preload scripts #39484

merged 1 commit into from Aug 22, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Aug 13, 2023 •
edited

Description of Change

Fixes #38161

Checklist

Release Notes

Notes: A dummy module.exports is now passed to the sandboxed preload scripts to improve compatibility with CommonJS modules.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 13, 2023
@miniak miniak self-assigned this Aug 13, 2023
@miniak miniak force-pushed the miniak/sandboxed-preload-module branch from 3440d2f to 85a7255 Compare August 14, 2023 09:16
@miniak miniak force-pushed the miniak/sandboxed-preload-module branch from 85a7255 to 0c0ae11 Compare August 14, 2023 09:18
@miniak miniak marked this pull request as ready for review August 14, 2023 09:18
@miniak miniak added semver/patch backwards-compatible bug fixes no-backport labels Aug 14, 2023
zcbenz
zcbenz approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@miniak
Copy link
Contributor Author

miniak commented Aug 15, 2023 •
edited

@zcbenz is this semver patch or minor? I am not sure

@zcbenz
Copy link
Member

zcbenz commented Aug 15, 2023

I'm not sure neither, I'm fine making it semver patch.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 15, 2023
@zcbenz zcbenz merged commit 3102a25 into main Aug 22, 2023
14 of 15 checks passed
@zcbenz zcbenz deleted the miniak/sandboxed-preload-module branch August 22, 2023 04:43
@release-clerk
Copy link

release-clerk bot commented Aug 22, 2023 •
edited by ckerr

Release Notes Persisted

Improve compatibility with CommonJS modules in sandboxed preload scripts by passing dummy module.exports.

win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@miniak
feat: expose dummy module.exports to the sandboxed preload scripts (e…
eca316b 
…lectron#39484)
@commit-lint commit-lint bot mentioned this pull request Nov 14, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
feat: expose dummy module.exports to the sandboxed preload scripts (e…
79173fa 
…lectron#39484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees

@miniak miniak

Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow commonjs2 scripts as sandboxed preload scripts
2 participants
@miniak @zcbenz