-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add missing webview render-process-gone
event
#39494
Conversation
6c6f945
to
fda5746
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs: lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of the Electron Docs Team
fda5746
to
22876ff
Compare
render-process-gone
event
@zcbenz I think it can be merged now |
No Release Notes |
I have automatically backported this PR to "27-x-y", please check out #39543 |
I have automatically backported this PR to "24-x-y", please check out #39544 |
I have automatically backported this PR to "26-x-y", please check out #39545 |
I have automatically backported this PR to "25-x-y", please check out #39546 |
docs: add mising webview 'render-process-gone' event
docs: add mising webview 'render-process-gone' event
It should match the
webContents
events, which are used to implement thewebview
ones:electron/docs/api/web-contents.md
Lines 463 to 496 in 9eeef55
Except for the
killed
argument, which is not being forwarded:electron/lib/browser/web-view-events.ts
Lines 24 to 25 in 9eeef55
Also adds
structures/render-process-gone-details.md
to eliminate duplicatesNotes: none