Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup asar initialization logic #39532

Merged
merged 1 commit into from Aug 17, 2023
Merged

chore: cleanup asar initialization logic #39532

merged 1 commit into from Aug 17, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 16, 2023 •
edited

Description of Change

Per conversation in https://github.com/nodejs-private/node-private/issues/466:

@codebytere If Electron is patching lib/internal/process/pre_execution.js anyway, can't you just store a reference to process._linkedBinding before policies are initialized, and then use the stored reference in setupAsarSupport()?

this PR clean up our asar initialization in a way that adheres to the security fix in https://github.com/nodejs-private/node-private/pull/460.

Checklist

Release Notes

Notes: none.

@codebytere codebytere added semver/patch backwards-compatible bug fixes no-backport labels Aug 16, 2023
@codebytere codebytere requested a review from a team as a code owner August 16, 2023 13:33
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 16, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 17, 2023
@codebytere codebytere merged commit aeb89b1 into main Aug 17, 2023
14 checks passed
@codebytere codebytere deleted the handle-policy-asar branch August 17, 2023 14:42
@release-clerk
Copy link

release-clerk bot commented Aug 17, 2023

No Release Notes

win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@codebytere
chore: cleanup asar initialization logic (electron#39532)
f1a45f0
@commit-lint commit-lint bot mentioned this pull request Nov 7, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
chore: cleanup asar initialization logic (electron#39532)
1dc375a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees
No one assigned
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @ckerr @zcbenz