Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow headers to be sent with webContents.downloadURL() #39560

feat: allow headers to be sent with webContents.downloadURL()

6027d20
Select commit
Loading
Failed to load commit list.
Merged

feat: allow headers to be sent with webContents.downloadURL() #39560

feat: allow headers to be sent with webContents.downloadURL()
6027d20
Select commit
Loading
Failed to load commit list.
Electron Archaeologist / Artifact Comparison completed Aug 17, 2023 in 1m 3s

Changes Detected

Looks like the electron.d.ts file changed.

--- a/electron.old.d.ts
+++ b/electron.new.d.ts
@@ -12260,7 +12260,7 @@ declare namespace Electron {
      * Initiates a download of the resource at `url` without navigating. The
      * `will-download` event of `session` will be triggered.
      */
-    downloadURL(url: string): void;
+    downloadURL(url: string, options?: DownloadURLOptions): void;
     /**
      * Enable device emulation with the given parameters.
      */
@@ -13937,7 +13937,7 @@ declare namespace Electron {
     /**
      * Initiates a download of the resource at `url` without navigating.
      */
-    downloadURL(url: string): void;
+    downloadURL(url: string, options?: DownloadURLOptions): void;
     /**
      * A promise that resolves with the result of the executed code or is rejected if
      * the result of the code is a rejected promise.