feat: enable WaylandWindowDecorations by default #39582
Conversation
VerteDinde
added
target/26-x-y
|
In theory, I'm fine with this change, but do we know what the state of upstream Chromium is regarding kWaylandWindowDecorations by default? If this is something that's also enabled in Chromium by default now, we may no longer even need this flag. (Note: I wouldn't hold the PR on removing it - I just think it would be helpful to understand how we're aligned/misaligned with Chromium if we do enable the flag by default) |
|
The Wayland requires clients to decorate themselves by default if they need decorations. It has a protocol to request server-side decorations called Chromium always draws its own decorations, both on X11 and Wayland, unless the "Use system title bar and borders" option is turned on. This option cannot be turned on in Wayland compositors without support for zxdg_decoration_manager_v1. Enabling WaylandWindowDecorations by default should make electron behave similar to Chromium. |
|
Thanks @aiddya, that's very helpful context 😄 In that case, this change looks good to me, thanks again for your contributions here! |
|
API LGTM |
|
No Release Notes |
|
I have automatically backported this PR to "27-x-y", please check out #39644 |
trop
bot
added
in-flight/27-x-y
and removed
target/27-x-y
|
I have automatically backported this PR to "26-x-y", please check out #39645 |
trop
bot
added
in-flight/26-x-y
merged/27-x-y
Contains electron 26 and 27 updates, for details see https://www.electronjs.org/blog/electron-26-0 https://www.electronjs.org/blog/electron-27-0 Mainly this should help with further bugfixes in webrtc as the contained Chromium is implicitly upgraded from 114 to 118. In wayland / pipewire terms we have only minor additions, eg: WaylandWindowDecorations by default: electron/electron#39582
Contains electron 26 and 27 updates, for details see https://www.electronjs.org/blog/electron-26-0 https://www.electronjs.org/blog/electron-27-0 Mainly this should help with further bugfixes in webrtc as the contained Chromium is implicitly upgraded from 114 to 118. In wayland / pipewire terms we have only minor additions, eg: WaylandWindowDecorations by default: electron/electron#39582 which means we can remove the enable flag we had on this in main.js as its now default.
Contains electron 26 and 27 updates, for details see https://www.electronjs.org/blog/electron-26-0 https://www.electronjs.org/blog/electron-27-0 Contains a fix for Linux that lead to crashes when the graphics drivers changed electron/electron#40467 Mainly this should help with further bugfixes in webrtc as the contained Chromium is implicitly upgraded from 114 to 118. In wayland / pipewire terms we have only minor additions, eg: WaylandWindowDecorations by default: electron/electron#39582 which means we can remove the enable flag we had on this in main.js as its now default.
Contains electron 26 and 27 updates, for details see https://www.electronjs.org/blog/electron-26-0 https://www.electronjs.org/blog/electron-27-0 Contains a fix for Linux that lead to crashes when the graphics drivers changed electron/electron#40467 Mainly this should help with further bugfixes in webrtc as the contained Chromium is implicitly upgraded from 114 to 118. In wayland / pipewire terms we have only minor additions, eg: WaylandWindowDecorations by default: electron/electron#39582 which means we can remove the enable flag we had on this in main.js as its now default.
Since electron/electron#39582 WaylandWindowDecorations are on by default, thus no longer the need to set this in the wrapper. This was part of electron 28 and was backported to electron 27 and 26, thus we can safely remove it from here as well.
Window decorations on wayland are enabled by default since electron v28 [1]. [1] electron/electron#39582
Window decorations on wayland are enabled by default since electron v28 [1]. [1] electron/electron#39582
Window decorations on wayland are enabled by default since electron v28 [1]. [1] electron/electron#39582
Description of Change
Reasons to enable the feature by default:
cc-ing reviewers of the original PR @nornagon @zcbenz @ckerr
Checklist
npm testpassesRelease Notes
Notes: no-notes