feat: expose app accessibility transparency settings api #39631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
reviewed
Aug 24, 2023
MarshallOfSound
requested changes
Aug 26, 2023
georgexu99
force-pushed
the
add-accessibility-display-should-reduce-transparency
branch
from
29afcd0
to
8b68f32
Compare
VerteDinde
approved these changes
Aug 30, 2023
|
failing tests seem to be flakes |
MarshallOfSound
approved these changes
Sep 5, 2023
|
API LGTM |
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
VerteDinde
added
target/26-x-y
georgexu99
force-pushed
the
add-accessibility-display-should-reduce-transparency
branch
from
f86cf55
to
ed92e6a
Compare
georgexu99
force-pushed
the
add-accessibility-display-should-reduce-transparency
branch
from
0fef536
to
ea0657f
Compare
georgexu99
force-pushed
the
add-accessibility-display-should-reduce-transparency
branch
from
ea0657f
to
665d3ec
Compare
georgexu99
force-pushed
the
add-accessibility-display-should-reduce-transparency
branch
from
443d816
to
b276606
Compare
VerteDinde
deleted the
add-accessibility-display-should-reduce-transparency
branch
|
Release Notes Persisted
|
|
I was unable to backport this PR to "26-x-y" cleanly; |
trop
bot
removed
the
target/26-x-y
|
I was unable to backport this PR to "27-x-y" cleanly; |
trop
bot
added
needs-manual-bp/26-x-y
needs-manual-bp/27-x-y
and removed
target/27-x-y
georgexu99
added a commit
that referenced
this pull request
Oct 2, 2023
* feat: expose app accessibility transparency settings api * docs: fix typo * chore: add doc * change to property * add as property instead of method * chore: fix lint * rename function name in header --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
5 tasks
|
@georgexu99 has manually backported this PR to "26-x-y", please check out #40073 |
georgexu99
added a commit
that referenced
this pull request
Oct 2, 2023
* feat: expose app accessibility transparency settings api * docs: fix typo * chore: add doc * change to property * add as property instead of method * chore: fix lint * rename function name in header --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
|
@georgexu99 has manually backported this PR to "27-x-y", please check out #40074 |
trop
bot
added
in-flight/27-x-y
merged/27-x-y
VerteDinde
added a commit
that referenced
this pull request
Oct 4, 2023
feat: expose app accessibility transparency settings api (#39631) * feat: expose app accessibility transparency settings api * docs: fix typo * chore: add doc * change to property * add as property instead of method * chore: fix lint * rename function name in header --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
trop
bot
added
merged/26-x-y
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Exposes an api that reads the System Preferences to determine whether the app avoids using semitransparent backgrounds. If the property is TRUE, don't use use semitransparent backgrounds in the UI.
This setting can be changed by choosing System Preferences > Accessibility > Display and selecting "Reduce transparency".
Checklist
npm testpassesRelease Notes
Notes: Added API to allow apps to determine whether to avoid using semitransparent backgrounds.