Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated webContents.getPrinters() #39663

Merged
merged 1 commit into from
Sep 5, 2023
Merged

chore: remove deprecated webContents.getPrinters() #39663

merged 1 commit into from
Sep 5, 2023

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Aug 26, 2023 •
edited by ckerr

Description of Change

Following up #39356 with the removal.

Checklist

Release Notes

Notes: Removed deprecated webContents.getPrinters().

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 26, 2023
@dsanders11 dsanders11 added target/27-x-y PR should also be added to the "27-x-y" branch. and removed new-pr 🌱 PR opened in the last 24 hours labels Aug 26, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 26, 2023
@dsanders11 dsanders11 added the semver/major incompatible API changes label Aug 26, 2023
@electron-cation
Copy link

electron-cation bot commented Aug 26, 2023 •
edited by jkleinsc

🪦 Deprecation Checklist

🗑️ Previous deprecations being removed in this PR

  • 🏷️ Pull request is labeled as semver/major incompatible API changes
  • 📢 Are called out as removed in docs/breaking-changes.md
  • 📝 Are fully removed from the docs
  • ⌨️ All relevant code is removed
  • 🧪 spec/ts-smoke is updated to use @ts-expect-error for the removed APIs

@electron/wg-releases: Please confirm these deprecation changes conform to our deprecation policies listed in docs/breaking-changes.md, then check the applicable items in the checklist and remove any non-applicable items.

@dsanders11 dsanders11 marked this pull request as ready for review August 28, 2023 19:17
@dsanders11 dsanders11 requested a review from a team as a code owner August 28, 2023 19:17
jkleinsc
jkleinsc approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

zcbenz
zcbenz approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

codebytere
codebytere approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere merged commit c96bb99 into main Sep 5, 2023
27 checks passed
@codebytere codebytere deleted the remove-deprecated-get-printers branch September 5, 2023 08:16
@release-clerk
Copy link

release-clerk bot commented Sep 5, 2023 •
edited by ckerr

Release Notes Persisted

Removed deprecated webContents.getPrinters().

@trop trop bot mentioned this pull request Sep 5, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Sep 5, 2023

I have automatically backported this PR to "27-x-y", please check out #39735

@trop trop bot added in-flight/27-x-y merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/27-x-y labels Sep 5, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@dsanders11
chore: remove deprecated webContents.getPrinters() (electron#39663)
d105c1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
api-review/approved ✅ deprecation-review/complete ✅ merged/27-x-y PR was merged to the "27-x-y" branch. semver/major incompatible API changes
Projects
Deprecation Board
Status: 🗑 Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dsanders11 @jkleinsc @zcbenz @codebytere