Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix return typing of ses.getExtension #39697

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Aug 30, 2023

Description of Change

This isn't being processed properly by electron/docs-parser, looks like it's due to multiple backticked types being union'd together, when we normally do it inside of the backticks. See the Artifact Comparison check output for difference.

Checklist

  • PR description included and stakeholders cc'd

Release Notes

Notes: none

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Aug 30, 2023
@dsanders11 dsanders11 added target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Aug 30, 2023
@dsanders11 dsanders11 marked this pull request as ready for review August 30, 2023 23:17
@MarshallOfSound MarshallOfSound merged commit 7858921 into main Aug 31, 2023
22 checks passed
@MarshallOfSound MarshallOfSound deleted the docs-ses-getExtension-return-typing branch August 31, 2023 01:10
@release-clerk
Copy link

release-clerk bot commented Aug 31, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Aug 31, 2023

I have automatically backported this PR to "26-x-y", please check out #39698

@trop trop bot added in-flight/26-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. labels Aug 31, 2023
@trop
Copy link
Contributor

trop bot commented Aug 31, 2023

I have automatically backported this PR to "27-x-y", please check out #39699

@trop trop bot added in-flight/27-x-y merged/27-x-y PR was merged to the "27-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/27-x-y in-flight/26-x-y labels Aug 31, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants