Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fixup autoninja #39899

Merged
merged 1 commit into from
Sep 19, 2023
Merged

build: fixup autoninja #39899

merged 1 commit into from
Sep 19, 2023

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 18, 2023

Backport of #39896

See that PR for details.

Notes: none

@trop @jkleinsc
chore: set GOMA_DIR for autoninja
887d516 
(cherry picked from commit 94f24bd)
(cherry picked from commit 90c1f6e)

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
@trop trop bot requested a review from jkleinsc September 18, 2023 20:45
@trop trop bot mentioned this pull request Sep 18, 2023
Merged
2 tasks
@trop trop bot added 22-x-y backport This is a backport PR semver/none labels Sep 18, 2023
@jkleinsc jkleinsc merged commit d892c2b into 22-x-y Sep 19, 2023
13 checks passed
@jkleinsc jkleinsc deleted the trop/22-x-y-bp-build-fixup-autoninja-1695069875450 branch September 19, 2023 00:36
@release-clerk
Copy link

release-clerk bot commented Sep 19, 2023

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
22-x-y backport This is a backport PR semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jkleinsc