Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tabbingIdentifier property to BrowserWindow #39980

Merged
merged 1 commit into from Oct 3, 2023
Merged

feat: add tabbingIdentifier property to BrowserWindow #39980

merged 1 commit into from Oct 3, 2023
+40 −6

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Sep 26, 2023 •
edited

Description of Change

Closes #18138.
Continues #18141 which was closed.

Add a tabbingIdentifier runtime property to BrowserWindow. This allows, for example, properly restoring an arrangement of multiple groups of tabs.

Checklist

Release Notes

Notes: Added a tabbingIdentifier property to BrowserWindow.

@codebytere codebytere added semver/minor backwards-compatible functionality target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Sep 26, 2023
@electron-cation electron-cation bot added api-review/requested 🗳 new-pr 🌱 PR opened in the last 24 hours labels Sep 26, 2023
ckerr
ckerr approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

shell/browser/native_window.h Outdated Show resolved Hide resolved
jkleinsc
jkleinsc reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

zcbenz
zcbenz approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@MarshallOfSound MarshallOfSound merged commit 713d8c4 into main Oct 3, 2023
18 checks passed
@MarshallOfSound MarshallOfSound deleted the tabbingidentifier branch October 3, 2023 19:27
@release-clerk
Copy link

release-clerk bot commented Oct 3, 2023

Release Notes Persisted

Added a tabbingIdentifier property to BrowserWindow.

@trop
Copy link
Contributor

trop bot commented Oct 3, 2023

I was unable to backport this PR to "26-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/26-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. labels Oct 3, 2023
@trop trop bot mentioned this pull request Oct 3, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 3, 2023

I have automatically backported this PR to "27-x-y", please check out #40082

@trop trop bot added in-flight/27-x-y merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/27-x-y labels Oct 3, 2023
@codebytere codebytere mentioned this pull request Nov 1, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Nov 1, 2023

@codebytere has manually backported this PR to "26-x-y", please check out #40410

@trop trop bot added in-flight/26-x-y merged/26-x-y PR was merged to the "26-x-y" branch. and removed needs-manual-bp/26-x-y in-flight/26-x-y labels Nov 1, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
feat: add tabbingIdentifier property to BrowserWindow (electron#3…
f2bb392 
…9980)

feat: add tabbingIdentifier property to BrowserWindow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
api-review/approved ✅ merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to retrieve window tabbingIdentifier at runtime
5 participants
@codebytere @ckerr @jkleinsc @zcbenz @MarshallOfSound