fix: detect screen readers by testing their existences #39988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
added
platform/windows
component/accessibility
semver/patch
codebytere
approved these changes
Sep 27, 2023
jkleinsc
approved these changes
Sep 27, 2023
|
Release Notes Persisted
|
|
/trop run backport-to 27-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I have automatically backported this PR to "27-x-y", please check out #40065 |
trop
bot
added
in-flight/27-x-y
merged/27-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The official way to get screen reader status on Windows is to call
SystemParametersInfo(SPI_GETSCREENREADER), which has false positives (for example when user is using touch screens) and will cause performance issues in some apps due to accessibility support getting turned on. (refs #7208)This PR takes another approach by directly testing whether the screen readers are actually running. This approach has been used in VS Code and Teams for a long time and has passed accessibility check in Microsoft.
Checklist
npm testpassesRelease Notes
Notes: Fix how screen readers are detected on Windows to reduce false positives.