Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failure on immutable webContents.print(options) #40030

Merged
merged 1 commit into from Sep 28, 2023
Merged

fix: failure on immutable webContents.print(options) #40030

merged 1 commit into from Sep 28, 2023

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 28, 2023

Backport of #39985

See that PR for details.

Notes: Fixed an issue where webContents.print could fail when options is a frozen object.

@trop @codebytere
fix: failure on immutable webContents.print(options)
e17cdd1 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested a review from codebytere September 28, 2023 08:43
@trop trop bot mentioned this pull request Sep 28, 2023
Merged
3 tasks
@trop trop bot added 27-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 28, 2023
@jkleinsc jkleinsc merged commit 7d21d11 into 27-x-y Sep 28, 2023
17 checks passed
@jkleinsc jkleinsc deleted the trop/27-x-y-bp-fix-failure-on-immutable-webcontents-print-options--1695890570921 branch September 28, 2023 16:48
@release-clerk
Copy link

release-clerk bot commented Sep 28, 2023

Release Notes Persisted

Fixed an issue where webContents.print could fail when options is a frozen object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
27-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @codebytere