Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cherry-pick c03569f from libuv #40101

Merged
merged 1 commit into from Oct 6, 2023
Merged

fix: cherry-pick c03569f from libuv #40101

merged 1 commit into from Oct 6, 2023

Conversation

deepak1556
Copy link
Member

Description of Change

Context: microsoft/pylance-release#1118 (comment)
Refs microsoft/vscode#186912

Release Notes

Notes: fix launch failure with child_process.spawn on windows affected by launching store applications

@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Oct 5, 2023
@deepak1556 deepak1556 requested a review from a team as a code owner October 5, 2023 11:53
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 5, 2023
@deepak1556 deepak1556 merged commit fdf8b02 into main Oct 6, 2023
23 checks passed
@deepak1556 deepak1556 deleted the robo/fix_spawn_windows branch October 6, 2023 10:25
@release-clerk
Copy link

release-clerk bot commented Oct 6, 2023 •
edited by ckerr

Release Notes Persisted

fix launch failure with child_process.spawn() on windows affected by launching store applications

@trop trop bot mentioned this pull request Oct 6, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 6, 2023

I have automatically backported this PR to "25-x-y", please check out #40125

@trop trop bot added in-flight/25-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. labels Oct 6, 2023
This was referenced Oct 6, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 6, 2023

I have automatically backported this PR to "27-x-y", please check out #40126

@trop
Copy link
Contributor

trop bot commented Oct 6, 2023

I have automatically backported this PR to "26-x-y", please check out #40127

@trop trop bot added in-flight/27-x-y in-flight/26-x-y merged/27-x-y PR was merged to the "27-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/27-x-y in-flight/26-x-y in-flight/25-x-y labels Oct 6, 2023
@ckerr ckerr changed the title chore: cherry-pick c03569f from libuv fix: cherry-pick c03569f from libuv Nov 28, 2023
@ckerr
Copy link
Member

ckerr commented Nov 28, 2023

In case anyone wonders, the reason for changing the title prefix from chore: to fix:, even though cherry-picking was a chore, is to make the release notes script happy.

Marking the title as a fix: ensures the Notes "Fixed launch failure..." shows up under the Fixes section instead of the Other Changes section 😸

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@deepak1556
chore: cherry-pick c03569f from libuv (electron#40101)
114ac6f 
Refs libuv/libuv@c03569f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deepak1556 @ckerr @jkleinsc @zcbenz