Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: all children showing when showing child window #40104

Merged
merged 1 commit into from Oct 9, 2023
Merged

fix: all children showing when showing child window #40104

merged 1 commit into from Oct 9, 2023

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 5, 2023

Backport of #40062

See that PR for details.

Notes: Fixes an issue where calling show() on a child BrowserWindow would show all other children attached to the same parent on macOS.

@trop trop bot requested a review from codebytere October 5, 2023 13:21
@trop trop bot mentioned this pull request Oct 5, 2023
Merged
4 tasks
@trop trop bot added 24-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 5, 2023
jkleinsc
jkleinsc previously requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like newly added test is failing due to once not being defined:

electron/spec/api-browser-window-spec.ts(4304,29): error TS2304: Cannot find name 'once'.
electron/spec/api-browser-window-spec.ts(4311,31): error TS2304: Cannot find name 'once'.

@trop @codebytere
fix: all children showing when showing child window
ecd3e68 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere codebytere force-pushed the trop/24-x-y-bp-fix-all-children-showing-when-showing-child-window-1696512045928 branch from 87acb9d to ecd3e68 Compare October 9, 2023 13:20
@VerteDinde VerteDinde dismissed jkleinsc’s stale review October 9, 2023 22:15

Changes addresses, test now passes

@VerteDinde VerteDinde merged commit d3c763f into 24-x-y Oct 9, 2023
12 of 13 checks passed
@VerteDinde VerteDinde deleted the trop/24-x-y-bp-fix-all-children-showing-when-showing-child-window-1696512045928 branch October 9, 2023 22:16
@release-clerk
Copy link

release-clerk bot commented Oct 9, 2023

Release Notes Persisted

Fixes an issue where calling show() on a child BrowserWindow would show all other children attached to the same parent on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
24-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkleinsc @miniak @codebytere @VerteDinde