Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent PopUpButtonHandler premature dealloc #40308

Merged
merged 1 commit into from Oct 26, 2023
Merged

fix: prevent PopUpButtonHandler premature dealloc #40308

merged 1 commit into from Oct 26, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Oct 23, 2023 •
edited

Description of Change

Closes #40284
Refs this roll

See here - turns out target is weak so we need to retain it elsewhere.

Checklist

Release Notes

Notes: Fixed an error changing file format in dialog.showOpenDialog on macOS.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Oct 23, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 23, 2023
@codebytere codebytere changed the title fix: prevent PopUpButtonHandler dealloc fix: prevent PopUpButtonHandler premature dealloc Oct 24, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 24, 2023
@codebytere codebytere merged commit 3f92a98 into main Oct 26, 2023
23 checks passed
@codebytere codebytere deleted the fix-popupbuttonhandler-dealloc branch October 26, 2023 15:40
@release-clerk
Copy link

release-clerk bot commented Oct 26, 2023

Release Notes Persisted

Fixed an error changing file format in dialog.showOpenDialog on macOS.

This was referenced Oct 26, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 26, 2023

I have automatically backported this PR to "28-x-y", please check out #40346

@trop trop bot added in-flight/28-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. labels Oct 26, 2023
@trop
Copy link
Contributor

trop bot commented Oct 26, 2023

I have automatically backported this PR to "27-x-y", please check out #40347

@trop trop bot added in-flight/27-x-y merged/28-x-y PR was merged to the "28-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/28-x-y in-flight/27-x-y labels Oct 26, 2023
@codebytere codebytere mentioned this pull request Oct 28, 2023
Closed
3 tasks
@stevebaxter
Copy link

Any news on when this might make it into a release?

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
fix: prevent PopUpButtonHandler premature dealloc (electron#40308)
461e420 
fix: prevent PopUpButtonHandler dealloc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees
No one assigned
Labels
merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to change file format in the openFile Dialog on Mac
3 participants
@codebytere @stevebaxter @MarshallOfSound