Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when thread isolated pool is enabled in the renderer process #40377

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

deepak1556
Copy link
Member

Description of Change

Data collected from the linked issue,

  1. Issue is isolated to Linux x64 users
  2. Issue does not happen with builds that had enable_pkeys = false
  3. Affected users run with renderer sandbox disabled which disables zygote in our case
  4. Some users have reported crash does not happen with Chromium 118
  5. I am unable to repro the issue on Ubuntu 22.04 vm with 4k page size, seems isolated to specific setups.

Given pkeys feature is only enabled on Linux x64 and is primarily used to implement thread isolated allocator whose consumer is v8 CFI which is currently disabled on this branch, I am inclined to disable the feature as there are no negative side effects. Also, given the issue is claimed to be addressed in Electron 27 and higher, this is an isolated fix which should make Electron 26 stable for the affected uesrs.

Fixes #39775

Release Notes

Notes: fix crash in renderer process due to partition allocator when sandbox is disabled

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 31, 2023
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 26-x-y and removed new-pr 🌱 PR opened in the last 24 hours labels Oct 31, 2023
@jkleinsc jkleinsc merged commit 92c9342 into 26-x-y Oct 31, 2023
14 checks passed
@jkleinsc jkleinsc deleted the robo/disable_pkeys_26_x_y branch October 31, 2023 21:00
Copy link

release-clerk bot commented Oct 31, 2023

Release Notes Persisted

fix crash in renderer process due to partition allocator when sandbox is disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants