fix: emit will-navigate for links in chrome: pages #40390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmaddock
added
semver/patch
ckerr
reviewed
Oct 31, 2023
| // ignore that. | ||
| // https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/navigator.cc;l=883-892;drc=0c8ffbe78dc0ef2047849e45cefb3f621043e956 | ||
| if (!is_renderer_initiated && | ||
| ui::PageTransitionIsWebTriggerable(handle->GetPageTransition())) { |
There was a problem hiding this comment.
(This was new to me, so tldr for other reviewers: true if it's a link, auto subframe, manual subframe, or form submission")
Co-authored-by: Charles Kerr <charles@charleskerr.com>
samuelmaddock
force-pushed
the
fix/webui-navigation
branch
from
8db3107
to
2f1e6fd
Compare
VerteDinde
approved these changes
Nov 14, 2023
|
Release Notes Persisted
|
This was referenced Nov 14, 2023
|
I have automatically backported this PR to "27-x-y", please check out #40524 |
trop
bot
added
in-flight/27-x-y
and removed
target/27-x-y
|
I have automatically backported this PR to "28-x-y", please check out #40525 |
trop
bot
added
in-flight/28-x-y
merged/28-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* fix: emit will-navigate for links in chrome: pages * test: will-navigate emitted from chrome: pages * Update shell/browser/electron_navigation_throttle.cc Co-authored-by: Charles Kerr <charles@charleskerr.com> --------- Co-authored-by: Charles Kerr <charles@charleskerr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Navigating to links within
chrome:pages—such as chrome://gpu—don't emit the "will-navigate" event. This is caused by navigations in pages with Web UI (e.g.chrome:pages) to always be set as browser-initiated requests.To fix this, we're overriding the browser-initiated flag for certain page transitions with navigations on Web UI pages. Pressing links is a link page transition while calling
loadURLuses a different page transition type.Checklist
npm testpassesRelease Notes
Notes: Fixed "will-navigate" not being emitted when pressing links in
chrome:pages.