fix: Do not activate app when calling focus on inactive panel window #40464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
5 tasks
trop
bot
added
27-x-y
backport
codebytere
requested changes
Nov 7, 2023
There was a problem hiding this comment.
../../electron/shell/browser/native_window_mac.mm:486:42: error: no known instance method for selector 'activate'
486 | [[NSApplication sharedApplication] activate];
| ^~~~~~~~
sdk/xcode_links/MacOSX13.3.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSApplication.h:158:12: note: receiver is instance of class declared here
158 | @interface NSApplication : NSResponder <NSUserInterfaceValidations, NSMenuItemValidation, NSAccessibilityElement, NSAccessibility>
| ^
1 error generated.
|
Closing this as we're still fine-tuning the actual calls. |
trop
bot
deleted the
trop/27-x-y-bp-fix-do-not-activate-app-when-calling-focus-on-inactive-panel-window-1699306709437
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #40307
See that PR for details.
Notes: Fixed app incorrectly activating panel windows on macOS Sonoma