fix: maximized window bounds when toggle setResizable #40503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
added
platform/windows
semver/patch
zcbenz
approved these changes
Nov 20, 2023
codebytere
approved these changes
Nov 21, 2023
|
Release Notes Persisted
|
This was referenced Nov 22, 2023
|
I have automatically backported this PR to "26-x-y", please check out #40580 |
trop
bot
removed
the
target/26-x-y
|
I have automatically backported this PR to "27-x-y", please check out #40581 |
|
I have automatically backported this PR to "28-x-y", please check out #40582 |
trop
bot
added
in-flight/27-x-y
in-flight/28-x-y
merged/28-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently when we toggle setResizable function on maximized window then this window will change bounds and will not be equal to screen bounds.
This is happening because when we toggle setResizable then also HWNDMessageHandler::SizeConstraintsChanged() is called, where WS_THICKFRAME window style is removed.
Solution for this issue is to add WS_THICKFRAME for maximized window even if window is not resizable.
Checklist
npm testpassesRelease Notes
Notes: Fix problem with bounds of maximized window when toggle BrowserWindow.setResizable function.