Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 1 changes from Release-1-M119 #40519

Merged
merged 2 commits into from Nov 14, 2023

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Nov 14, 2023

electron/security#424 - 3df423a5b8de from chromium Check context status before recreating platform destination

Changing the channel count in the RealtimeAudioDestinationHandler will
trigger the recreation of the platform destination. This in turn can
activate the audio rendering thread.

This CL adds a check to prevent this from happening after the handler
is garbage collected.

(cherry picked from commit 4997f2ba263ff7e1dbc7987dd3665459be14dffe)

Bug: 1497859
Test: Locally confirmed with ASAN
Change-Id: I5d2649f3fd3639779ae40b0ca4ef2fe305653421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4995928
Commit-Queue: Hongchan Choi hongchan@chromium.org
Reviewed-by: Michael Wilson mjwilson@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#1217868}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5004961
Bot-Commit: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Cr-Commit-Position: refs/branch-heads/5993@{#1520}
Cr-Branched-From: 511350718e646be62331ae9d7213d10ec320d514-refs/heads/main@{#1192594}

Notes:

@ppontes ppontes requested a review from a team as a code owner November 14, 2023 08:57
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 25-x-y labels Nov 14, 2023
@VerteDinde VerteDinde merged commit 6c37483 into 25-x-y Nov 14, 2023
13 checks passed
@VerteDinde VerteDinde deleted the cherry-pick/security/25-x-y/release-1-m119 branch November 14, 2023 20:54
Copy link

release-clerk bot commented Nov 14, 2023

Release Notes Persisted

  • Security: backported fix for CVE-2023-5996.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants