Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add patch for simdutf base64 crash #40536

Merged
merged 1 commit into from Nov 16, 2023
Merged

fix: add patch for simdutf base64 crash #40536

merged 1 commit into from Nov 16, 2023

Conversation

MarshallOfSound
Copy link
Member

Supersedes #40446

Notes: Backported fix for AVX related crashes on certain linux machines

@MarshallOfSound MarshallOfSound added semver/patch backwards-compatible bug fixes target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Nov 15, 2023
@MarshallOfSound MarshallOfSound requested a review from a team as a code owner November 15, 2023 21:35
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 15, 2023
@MarshallOfSound MarshallOfSound mentioned this pull request Nov 15, 2023
Merged
1 task
@VerteDinde VerteDinde mentioned this pull request Nov 15, 2023
Closed
@hardfalcon
Copy link

This issue likely also affects Electron's 25-x-y branch because node 18.15.0 also contains the same code:
https://github.com/nodejs/node/blob/v18.15.0/deps/base64/base64/lib/codec_choose.c#L197

@MarshallOfSound
Copy link
Member Author

Per https://www.electronjs.org/docs/latest/tutorial/electron-timelines#version-support-policy v25 is only receiving security fixes at the moment

@MarshallOfSound MarshallOfSound merged commit dec96ac into main Nov 16, 2023
23 of 24 checks passed
@MarshallOfSound MarshallOfSound deleted the simdutf-fix branch November 16, 2023 04:11
@release-clerk Release Clerk
Copy link

release-clerk bot commented Nov 16, 2023

Release Notes Persisted

Backported fix for AVX related crashes on certain linux machines

This was referenced Nov 16, 2023
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Nov 16, 2023

I have automatically backported this PR to "26-x-y", please check out #40540

@trop trop bot added in-flight/26-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. labels Nov 16, 2023
@trop
Copy link
Contributor

trop bot commented Nov 16, 2023

I have automatically backported this PR to "27-x-y", please check out #40541

@trop
Copy link
Contributor

trop bot commented Nov 16, 2023

I have automatically backported this PR to "28-x-y", please check out #40542

@trop trop bot added in-flight/27-x-y in-flight/28-x-y and removed target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Nov 16, 2023
@hardfalcon
Copy link

hardfalcon commented Nov 18, 2023 •
edited

I've just noticed that the commit message on this seems to be mixed up.

There are two distinct issues related to faulty AVX detection in electron's node dependency:

  • one in node's base64, and
  • another one in node's simdutf.

This PR only fixes the issue in the base64 library, but not the issue in the simdutf library. For the latter one, see #40446.

@trop trop bot added the merged/27-x-y PR was merged to the "27-x-y" branch. label Nov 28, 2023
@trop trop bot added merged/26-x-y PR was merged to the "26-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. and removed in-flight/27-x-y in-flight/26-x-y in-flight/28-x-y labels Nov 28, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@MarshallOfSound
fix: add patch for simdutf base64 crash (electron#40536)
8ea1cd8
@xmfcx xmfcx mentioned this pull request Dec 21, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarshallOfSound @hardfalcon @jkleinsc @VerteDinde