fix: add missing set_wants_to_be_visible(true) to NativeWindowMac::ShowInactive()

[tzahola]

Description of Change

PR #40062 introduced a bool wants_to_be_visible_ flag to NativeWindowMac, but it wasn't set in NativeWindowMac::ShowInactive(), only in NativeWindowMac::Show(). This meant that the parent-child relationship wouldn't be established for any window that was opened while the app wasn't the active one (typically this can occur in apps with always-visible floating overlay windows).

CC @codebytere

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: fixed child window opening in non-active macOS apps

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[codebytere]

@tzahola would you be willing to add a test for this?

[tzahola]

@tzahola would you be willing to add a test for this?

I'll try!

[tzahola]

@tzahola would you be willing to add a test for this?

I'm afraid I can't really do this, because I can't even run the tests on the current main, due to third_party/electron_node:headers being a non-existent target:

$ ninja -C out/Testing third_party/electron_node:headers
ninja: Entering directory `out/Testing'
ninja: error: unknown target 'third_party/electron_node:headers'

Which then causes npm run test to fail with:

gyp: /.../electron/src/out/Testing/gen/node_headers/common.gypi not found (cwd: /.../electron/src/electron/spec/node_modules/@electron-ci/uv-dlopen) while reading includes of binding.gyp while trying to load binding.gyp

Any idea why this is the case?

[tzahola]

Ok, it seems that in bfa58df the Node headers target was moved from third_party/node_electron:headers to electron:node_headers, but this wasn't updated in the docs.

[codebytere]

@tzahola are you using https://github.com/electron/build-tools? it makes everything much easier.

[tzahola]

@codebytere added test: cf73ec9

[codebytere]

Thanks!

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[release-clerk]

Release Notes Persisted

fixed child window opening in non-active macOS apps

[trop]

I have automatically backported this PR to "26-x-y", please check out #40657

[trop]

I have automatically backported this PR to "27-x-y", please check out #40658

[trop]

I have automatically backported this PR to "28-x-y", please check out #40659