fix: Use activateIgnoringOtherApps for non-panels #40570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
felixrieseberg
added
target/28-x-y
MarshallOfSound
approved these changes
Nov 20, 2023
codebytere
approved these changes
Nov 21, 2023
|
Release Notes Persisted
|
|
I have automatically backported this PR to "28-x-y", please check out #40621 |
trop
bot
added
in-flight/28-x-y
merged/28-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Use activateIgnoringOtherApps for non-panels
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR builds on top of #40307, which switched out the now-deprecated
activateIgnoringOtherAppsfor the newactivate. Thanks to #40307 (comment), we now know that the new API doesn't quite behave exactly like the old one - so we'll useactivatewhereactivateIgnoringOtherAppsis broken on macOS Sonoma — and in all other cases, continue to useactivateIgnoringOtherApps.Checklist
npm testpassesRelease Notes
Notes: Use
activateIgnoringOtherAppsfor focusing non-panels on macOS