fix: potential async_hooks crash in NotifyWindowRestore on Windows

[codebytere]

Description of Change

Closes #40573.

Fixes an issue where an async_hooks crash could occur on Windows only if the user is listening to the restore event after minimizing a maximized window and an error occurs in the restore callback. This was happening after 6b97beb, which created the first instance in our entire codebase where two Emit calls were called sequentially. As a result, given they were in the same callbackscope, when node::RunTimers ran and an error was occurring in the previous handler, async_hooks would blow up.

This fixes that error by putting the first Emit in its own CallbackScope.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed a potential async_hooks crash when listening for the restore event on Windows after minimizing a maximized BrowserWindow.

[zcbenz]

Does it fix the problem if we wrap every Emit with a node::CallbackScope? i.e. Put the node::CallbackScope in CallMethodWithArgs at event_emitter_caller.cc.

Sequential emits is rare but it seems impossible to patch all corner cases, for example, the drag-ended and drop events of Tray emit in one tick:
https://github.com/electron/electron/blob/main/shell/browser/ui/tray_icon_cocoa.mm#L303-L309

So I would prefer a generic solution than patching each corner case.

[zcbenz]

The failing linux-x64-testing-asan-tests does not seem to be flaky.

[codebytere]

autoUpdater is then only place in the codebase we use gin to emit a proper Error object. By using gin::EmitEvent to emit the Error object (thus adding a new CallbackScope there), and because Errors are handled specially in Node.js, we would otherwise trigger the uncaught exception handler to bypass the try/catch in our autoUpdate specs.

Either we add CallbackScopes on a case-by-case basis (as i initially tried in this PR) or we account for this edge case. I've chosen to account for this edge case.

[release-clerk]

Release Notes Persisted

Fixed a potential async_hooks crash when listening for the restore event on Windows after minimizing a maximized BrowserWindow.

[trop]

I was unable to backport this PR to "26-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "27-x-y", please check out #41144

[trop]

I have automatically backported this PR to "28-x-y", please check out #41145

[trop]

I have automatically backported this PR to "29-x-y", please check out #41146