Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix release notes script bug that omitted edited release-clerk comments #40634

Merged
merged 2 commits into from Nov 30, 2023
Merged

build: fix release notes script bug that omitted edited release-clerk comments #40634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3b90b2
build: fix release notes script bug that omitted edited release-clerk…
ckerr Nov 29, 2023
62cbc5f
fixup! build: fix release notes script bug that omitted edited releas…
ckerr Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion script/release/notes/notes.js
View file
Open in desktop
Expand Up @@ -99,7 +99,7 @@ const getNoteFromClerk = async (ghKey) => {

const CLERK_LOGIN = 'release-clerk[bot]';
const CLERK_NO_NOTES = '**No Release Notes**';
const PERSIST_LEAD = '**Release Notes Persisted**\n\n';
const PERSIST_LEAD = '**Release Notes Persisted**';
const QUOTE_LEAD = '> ';

for (const comment of comments.data.reverse()) {
Expand Down Expand Up @@ -130,6 +130,8 @@ const getNoteFromClerk = async (ghKey) => {
.trim();
}
}

console.warn(`WARN: no notes found in ${buildPullURL(ghKey)}`);
};

/**
Expand Down