Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webview zoom level persistence on navigation #40650

Merged
merged 1 commit into from
Dec 4, 2023

fix: webview zoom level persistence on navigation

a0bb087
Select commit
Failed to load commit list.
Merged

fix: webview zoom level persistence on navigation #40650

fix: webview zoom level persistence on navigation
a0bb087
Select commit
Failed to load commit list.
trop / Backportable? - 28-x-y completed Dec 4, 2023 in 19s

Backport Failed

This PR was checked and could not be automatically backported to "28-x-y" cleanly

Details

Failed Diff:

diff --cc spec/node-spec.ts
index 1369b6957e,2f8dd5218d..0000000000
--- a/spec/node-spec.ts
+++ b/spec/node-spec.ts
@@@ -873,7 -873,13 +873,17 @@@ describe('node feature', () => 
        });
      };
  
++<<<<<<< HEAD
 +    process.once('unhandledRejection', () => done('catch block is delayed to next tick'));
++=======
+     let called = false;
+     process.once('unhandledRejection', () => {
+       if (called) return;
+ 
+       done(new Error('catch block is delayed to next tick'));
+       called = true;
+     });
++>>>>>>> fix: webview zoom level persistence on navigation
  
      setTimeout(() => {
        f3().catch(() => done());

Annotations

Check failure on line 876 in spec/node-spec.ts

See this annotation in the file changed.

@trop trop / Backportable? - 28-x-y

spec/node-spec.ts#L876

Patch Conflict
Raw output
++<<<<<<< HEAD
 +    process.once('unhandledRejection', () => done('catch block is delayed to next tick'));
++=======
+     let called = false;
+     process.once('unhandledRejection', () => {
+       if (called) return;
+ 
+       done(new Error('catch block is delayed to next tick'));
+       called = true;
+     });
++>>>>>>> fix: webview zoom level persistence on navigation