Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong default port in docs #40665

Merged
merged 1 commit into from Dec 11, 2023
Merged

fix: wrong default port in docs #40665

merged 1 commit into from Dec 11, 2023

Conversation

hrimhari
Copy link
Contributor

@hrimhari hrimhari commented Nov 30, 2023

Description of Change

Wrong default port when debugging. See https://www.electronjs.org/docs/latest/api/command-line-switches#--inspecthostport

Checklist

Release Notes

Notes: Fixed documentation of the default --inspect port.

Copy link

welcome bot commented Nov 30, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 30, 2023
@ckerr
Copy link
Member

ckerr commented Dec 6, 2023

Looks like Node.js set kDefaultInspectorPort = 9229 in nodejs/node#22392

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 7, 2023
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Dec 11, 2023
@jkleinsc jkleinsc merged commit 5094cb4 into electron:main Dec 11, 2023
27 checks passed
Copy link

welcome bot commented Dec 11, 2023

Congrats on merging your first pull request! 🎉🎉🎉

Copy link

release-clerk bot commented Dec 11, 2023

Release Notes Persisted

Fixed documentation of the default --inspect port.

@trop
Copy link
Contributor

trop bot commented Dec 11, 2023

I have automatically backported this PR to "27-x-y", please check out #40742

@trop trop bot added in-flight/27-x-y and removed target/27-x-y PR should also be added to the "27-x-y" branch. labels Dec 11, 2023
@trop
Copy link
Contributor

trop bot commented Dec 11, 2023

I have automatically backported this PR to "28-x-y", please check out #40743

@trop trop bot added in-flight/28-x-y merged/28-x-y PR was merged to the "28-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/28-x-y PR should also be added to the "28-x-y" branch. in-flight/28-x-y in-flight/27-x-y labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants