Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up devtools frontend_host on webcontents destroy #40666

Merged
merged 3 commits into from
Dec 1, 2023
Merged

fix: clean up devtools frontend_host on webcontents destroy #40666

merged 3 commits into from
Dec 1, 2023

Commits on Dec 1, 2023

  1. fix: clean up devtools frontend_host on destroy

    @albertxing
    albertxing committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    3eebf8c View commit details
    Browse the repository at this point in the history

  2. chore: use IsInPrimaryMainFrame instead of IsInMainFrame

    @albertxing
    albertxing committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    dfbdb27 View commit details
    Browse the repository at this point in the history

  3. test: add a test for re-opening devtools

    @albertxing
    albertxing committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    fe26e4e View commit details
    Browse the repository at this point in the history