chore: cleanup tests creating crashpad handler in the test runner process #40668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Dec 1, 2023
|
Interestingly, all crash related specs for utility process failed only on windows ia32 CI. |
|
All the failing tests rely on error handling from the mojo pipe between process to determine the state of the process, and seems these handlers are not invoked in the ia32 case but worked before because exception handlers were registered by crashpad client ? Also, seems this issue is not new we had a similar occurrence before #34021, |
deepak1556
force-pushed
the
robo/fix_crash_test
branch
from
b34e576
to
9a3396f
Compare
|
Debugging showed that process termination status in the crash scenarios ended up after the test timeout, very likely a delay in https://source.chromium.org/chromium/chromium/src/+/main:base/process/kill_win.cc;l=26-63. Increasing timeout of tests didn't help all failing tests. Also given this does not repro locally, I am going to disable them for win32 ia32 flavor moving forward. |
codebytere
approved these changes
Dec 12, 2023
|
/trop run backport-to 27-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
/trop run backport-to 28-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
trop bot
added a commit
that referenced
this pull request
Jan 18, 2024
…cess (#40668) * chore: cleanup tests creating crashpad handler in the test runner process * ci: logging * ci: enable logging * ci: more logging * ci: run all tests * ci: more logging * ci: increase timeout * Revert "ci: increase timeout" This reverts commit 870f744. * Revert "ci: more logging" This reverts commit 46837f8. * Revert "ci: run all tests" This reverts commit 6a7889c. * Revert "ci: more logging" This reverts commit 351473a. * Revert "ci: enable logging" This reverts commit 194109e. * Revert "ci: logging" This reverts commit 9a3396f. * chore: disable flaky ia32 tests Co-authored-by: Robo <hop2deep@gmail.com>
|
I have automatically backported this PR to "27-x-y", please check out #41050 |
trop bot
added a commit
that referenced
this pull request
Jan 18, 2024
…cess (#40668) * chore: cleanup tests creating crashpad handler in the test runner process * ci: logging * ci: enable logging * ci: more logging * ci: run all tests * ci: more logging * ci: increase timeout * Revert "ci: increase timeout" This reverts commit 870f744. * Revert "ci: more logging" This reverts commit 46837f8. * Revert "ci: run all tests" This reverts commit 6a7889c. * Revert "ci: more logging" This reverts commit 351473a. * Revert "ci: enable logging" This reverts commit 194109e. * Revert "ci: logging" This reverts commit 9a3396f. * chore: disable flaky ia32 tests Co-authored-by: Robo <hop2deep@gmail.com>
|
I have automatically backported this PR to "28-x-y", please check out #41051 |
|
/trop run backport-to 29-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I have automatically backported this PR to "29-x-y", please check out #41053 |
jkleinsc
added a commit
that referenced
this pull request
Jan 19, 2024
…cess (#41049) chore: cleanup tests creating crashpad handler in the test runner process (#40668) * chore: cleanup tests creating crashpad handler in the test runner process * ci: logging * ci: enable logging * ci: more logging * ci: run all tests * ci: more logging * ci: increase timeout * Revert "ci: increase timeout" This reverts commit 870f744. * Revert "ci: more logging" This reverts commit 46837f8. * Revert "ci: run all tests" This reverts commit 6a7889c. * Revert "ci: more logging" This reverts commit 351473a. * Revert "ci: enable logging" This reverts commit 194109e. * Revert "ci: logging" This reverts commit 9a3396f. * chore: disable flaky ia32 tests (cherry picked from commit 83f15bd) Co-authored-by: Robo <hop2deep@gmail.com>
trop
bot
added
merged/26-x-y
jkleinsc
pushed a commit
that referenced
this pull request
Jan 19, 2024
…cess (#41050) chore: cleanup tests creating crashpad handler in the test runner process (#40668) * chore: cleanup tests creating crashpad handler in the test runner process * ci: logging * ci: enable logging * ci: more logging * ci: run all tests * ci: more logging * ci: increase timeout * Revert "ci: increase timeout" This reverts commit 870f744. * Revert "ci: more logging" This reverts commit 46837f8. * Revert "ci: run all tests" This reverts commit 6a7889c. * Revert "ci: more logging" This reverts commit 351473a. * Revert "ci: enable logging" This reverts commit 194109e. * Revert "ci: logging" This reverts commit 9a3396f. * chore: disable flaky ia32 tests Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Robo <hop2deep@gmail.com>
trop
bot
added
merged/27-x-y
jkleinsc
pushed a commit
that referenced
this pull request
Jan 19, 2024
…cess (#41051) chore: cleanup tests creating crashpad handler in the test runner process (#40668) * chore: cleanup tests creating crashpad handler in the test runner process * ci: logging * ci: enable logging * ci: more logging * ci: run all tests * ci: more logging * ci: increase timeout * Revert "ci: increase timeout" This reverts commit 870f744. * Revert "ci: more logging" This reverts commit 46837f8. * Revert "ci: run all tests" This reverts commit 6a7889c. * Revert "ci: more logging" This reverts commit 351473a. * Revert "ci: enable logging" This reverts commit 194109e. * Revert "ci: logging" This reverts commit 9a3396f. * chore: disable flaky ia32 tests Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Robo <hop2deep@gmail.com>
trop
bot
added
merged/28-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while debugging CI failure in #40017 (comment)
Test
allows the submitURL option to be omitted when uploadToServer is falsewas accidentally start the crashpad handler process and it impacted crashpad clients for processes that were created in tests unrelated later down the path.Release Notes
Notes: no-notes