fix: cherry pick 9009d76968b1ec2ed825bc95e47d086ceea07520 from chromium #40681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Dec 2, 2023
deepak1556
approved these changes
Dec 4, 2023
|
Release Notes Persisted
|
electron-cation
bot
added
new-pr 🌱
|
Thanks for the quick merge! @deepak1556 is there any chance that this can get back ported? |
deepak1556
added
target/27-x-y
|
/trop run backport |
|
The backport process for this PR has been manually initiated - here we go! :D |
This was referenced Dec 4, 2023
|
I have automatically backported this PR to "27-x-y", please check out #40687 |
trop
bot
added
in-flight/27-x-y
and removed
target/27-x-y
|
I have automatically backported this PR to "28-x-y", please check out #40688 |
trop
bot
added
in-flight/28-x-y
merged/28-x-y
ryanthemanuel
added a commit
to ryanthemanuel/electron
that referenced
this pull request
Dec 6, 2023
See that PR for details. Notes: Fixed an issue where font requests were incorrectly being sent to dev tools multiple times per resource.
|
@ryanthemanuel has manually backported this PR to "27-x-y", please check out #40715 |
ryanthemanuel
added a commit
to ryanthemanuel/electron
that referenced
this pull request
Dec 7, 2023
See that PR for details. Notes: Fixed an issue where font requests were incorrectly being sent to dev tools multiple times per resource.
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…um (electron#40681) * chore: cherry pick 9009d76968b1ec2ed825bc95e47d086ceea07520 from chromium * update patch message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds a chromium patch to address this issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1502591
This issue was corrected in chromium version 121.0.6157.0 in CL: chromium-review.googlesource.com/c/chromium/src/+/5033885
I've added this patch in an effort to get this fix sooner and potentially in older versions of electron as well.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where font requests were incorrectly being sent to dev tools multiple times per resource.