chore: add disclaimer to release timeline #40717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Dec 7, 2023
VerteDinde
force-pushed
the
releases-disclaimer
branch
from
160ac03
to
ff95651
Compare
VerteDinde
force-pushed
the
releases-disclaimer
branch
from
ff95651
to
565fdb0
Compare
VerteDinde
added
target/28-x-y
dsanders11
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Suggestion: We put any dates which are subject to change in the table in italics with an asterisk at the end, to help provide more of a visual cue.
The disclaimer feels like it's just repeating the information that already exists below, I'm tempted to cut it to just the blurb that says dates are subject to change due to upstream.
codebytere
approved these changes
Dec 9, 2023
ckerr
approved these changes
Dec 12, 2023
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
jkleinsc
approved these changes
Jan 4, 2024
|
No Release Notes |
This was referenced Jan 4, 2024
|
I have automatically backported this PR to "28-x-y", please check out #40884 |
trop
bot
added
in-flight/28-x-y
and removed
target/28-x-y
|
I have automatically backported this PR to "29-x-y", please check out #40885 |
trop
bot
added
in-flight/29-x-y
merged/29-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow up to #40622 - we caught a change in Chromium's schedule fairly late in the game, and updated the timeline doc after apps may have set their own schedules depending on the previous EOL date.
While we should always make sure this table is accurate, this PR adds a disclaimer to the timeline to clarify that the last 3 stable versions are supported, and how dates are determined.
Checklist
npm testpassesRelease Notes
Notes: none