Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note accelerator case insensitivity #40783

Merged
merged 3 commits into from Jan 4, 2024
Merged

Conversation

machuii
Copy link
Contributor

@machuii machuii commented Dec 18, 2023

Description of Change

Closes #38673.

Explicitly state that accelerators are case insensitive

Checklist

Release Notes

Notes: none

As requested in PR#38673 , a line has been added that explicitly states that accelerators are case sensitive
Copy link

welcome bot commented Dec 18, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 18, 2023
docs/api/accelerator.md Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 25, 2023
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accelerators are case insensitive.
When looking up the values we convert the passed in values to lowercase to perform case insensitive lookups: eg https://github.com/electron/electron/blob/main/shell/common/keyboard_util.cc#L279

machuii and others added 2 commits January 3, 2024 10:32
Co-authored-by: Erick Zhao <erick@hotmail.ca>
@codebytere codebytere changed the title Fix PR#38673 docs: note accelerator case insensitivity Jan 3, 2024
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes labels Jan 3, 2024
@jkleinsc jkleinsc merged commit 3a06047 into electron:main Jan 4, 2024
21 checks passed
Copy link

welcome bot commented Jan 4, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Copy link

release-clerk bot commented Jan 4, 2024

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Document if accelerators are case insensitive or not
3 participants