fix: make grant_file_protocol_extra_privileges fuse also block CORS fetches #40801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
added
security 🔒
semver/patch
electron-cation
bot
added
new-pr 🌱
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
VerteDinde
approved these changes
Jan 2, 2024
| // after this call, it won't override our asar factory, but if asar support | ||
| // breaks in future, please check if Chromium has changed the call. | ||
| factories->emplace(url::kFileScheme, AsarURLLoaderFactory::Create()); | ||
| if (electron::fuses::IsGrantFileProtocolExtraPrivilegesEnabled()) { |
There was a problem hiding this comment.
Since all of this logic is moved behind a fuse now, could this potentially break any existing implementations? Only asking because I wonder if we should call it out in breaking changes if so
There was a problem hiding this comment.
The fuse defaults to being enabled, so behavior without touching the fuse should be unchanged
|
Release Notes Persisted
|
|
I have automatically backported this PR to "29-x-y", please check out #40864 |
trop
bot
added
in-flight/29-x-y
merged/29-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds new testing infrastructure for fuses, and uses it to add a test for
the grant_file_protocol_extra_privileges fuse. Also, fix a bug with the
implementation of that fuse.
Checklist
npm testpassesRelease Notes
Notes: Fixed the
GrantFileProtocolExtraPrivilegesnot correctly preventingfetch()calls tofile://URLs.