refactor: make NativeWindow getter methods const #40804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
semver/patch
electron-cation
bot
added
new-pr 🌱
ckerr
force-pushed
the
refactor/constify-native-window-methods
branch
from
94962ce
to
56931cd
Compare
|
No Release Notes |
|
I was unable to backport this PR to "29-x-y" cleanly; |
trop
bot
added
needs-manual-bp/29-x-y
and removed
target/29-x-y
ckerr
added a commit
that referenced
this pull request
Jan 4, 2024
* refactor: make NativeWindow getter methods const * fixup! refactor: make NativeWindow getter methods const make GetZOrderLevel() const * fixup! refactor: make NativeWindow getter methods const fix oops
ckerr
added a commit
that referenced
this pull request
Jan 4, 2024
* refactor: make NativeWindow getter methods const * fixup! refactor: make NativeWindow getter methods const make GetZOrderLevel() const * fixup! refactor: make NativeWindow getter methods const fix oops
trop
bot
added
merged/29-x-y
codebytere
pushed a commit
that referenced
this pull request
Jan 5, 2024
refactor: make NativeWindow getter methods const (#40804) * refactor: make NativeWindow getter methods const * fixup! refactor: make NativeWindow getter methods const make GetZOrderLevel() const * fixup! refactor: make NativeWindow getter methods const fix oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Make the getter methods in
NativeWindow(e.g.IsVisible(),IsMaximized(), etc.) const.No particular stakeholders; all reviews welcome.
Checklist
npm testpassesRelease Notes
Notes: none