fix: ignore all NODE_ envs from foreign parent in node process #40882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trop
bot
added
26-x-y
backport
5 tasks
codebytere
approved these changes
Jan 4, 2024
ckerr
approved these changes
Jan 4, 2024
zcbenz
force-pushed
the
node-env-check-26
branch
2 times, most recently
from
ad297d4
to
72c196e
Compare
zcbenz
force-pushed
the
node-env-check-26
branch
from
72c196e
to
74a1350
Compare
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #40770
See that PR for details.
Notes: Unset all Node envs in node process when parent is a foreign process.