fix: crash using powerMonitor before ready event

[codebytere]

Description of Change

Closes #40694.
Refs #37937.

This PR fixes a crash resultant in trying to listen to power-related events before the ready event is emitted on Linux. This was happening because the PowerObserverLinux ctor called bluez::BluezDBusThreadManager::Get(), which assumed that bluez::BluezDBusThreadManager::Initialize() had already been called and CHECKed if it hadn't been. However, our existing logic did not call bluez::BluezDBusThreadManager::Initialize() until ElectronBrowserMainParts::PostCreateMainMessageLoop(), which meant that trying to use:

  powerMonitor.on('suspend', () => {
    console.log('suspend')
  });

  powerMonitor.on('resume', () => {
    console.log('resume')
  });

before the ready event would immediately die. I chose to fix this by calling bluez::BluezDBusThreadManager::Initialize() as soon as it was needed, and adding a check to ensure that it was not initialized more than once. Alternately, we can bring back the ready event requirement.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed a crash resultant from trying to listen to power-related events before the ready event was emitted on Linux.

[nornagon]

lazy initialize seems like a good approach to me 👍🏻

[deepak1556]

Minor nit: wouldn't it be better to continue using the wrapper class to avoid missing any additional bluez initialization or shutdown paths that might get added in future ?

if (!bluez::BluezDBusManager::IsInitialized())
  bluez::DBusBluezManagerWrapperLinux::Initialize();

[codebytere]

@deepak1556 done!

[deepak1556]

Thanks!

[codebytere]

Failing test unrelated:

reporting api sends a report for an intervention

[release-clerk]

Release Notes Persisted

Fixed a crash resultant from trying to listen to power-related events before the ready event was emitted on Linux.

[trop]

I have automatically backported this PR to "26-x-y", please check out #40922

[trop]

I have automatically backported this PR to "27-x-y", please check out #40923

[trop]

I have automatically backported this PR to "28-x-y", please check out #40924

[trop]

I have automatically backported this PR to "29-x-y", please check out #40925