Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable #40896

Merged
merged 4 commits into from
Jan 8, 2024
Merged

fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable #40896

merged 4 commits into from
Jan 8, 2024

Commits on Jan 5, 2024

  1. fix: macOS maximize button shouldn't be disabled just because the win… 

    …dow is non-fullscreenable

Co-authored-by: Tamás Zahola <tzahola@gmail.com>
    @trop @tzahola
    trop[bot] and tzahola committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    963924e View commit details
    Browse the repository at this point in the history

  2. add test 

    Co-authored-by: Tamás Zahola <tzahola@gmail.com>
    @trop @tzahola
    trop[bot] and tzahola committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    ec82293 View commit details
    Browse the repository at this point in the history

  3. fix test by enabling maximize button if `resizable && (maximizable ||… 

    … fullscreenable)` instead of `(resizable && maximizable) && fullscreenable`

Co-authored-by: Tamás Zahola <tzahola@gmail.com>
    @trop @tzahola
    trop[bot] and tzahola committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    263a45f View commit details
    Browse the repository at this point in the history

  4. chore: update patches

    @patchup
    patchup[bot] committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    8e3b4ca View commit details
    Browse the repository at this point in the history