New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wide string concatenation #40909
fix: wide string concatenation #40909
Conversation
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: clavin <clavin@electronjs.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTBTS:
../../electron/shell/browser/browser_win.cc(145,44): error: no member named 'AsWStringView' in namespace 'base'; did you mean 'AsWStringPiece'?
145 | *exe = base::StrCat({*exe, L" ", base::AsWStringView(joined_launch_args)});
| ~~~~~~^~~~~~~~~~~~~
| AsWStringPiece
../..\base/strings/string_util_win.h(94,21): note: 'AsWStringPiece' declared here
94 | inline WStringPiece AsWStringPiece(StringPiece16 str) {
| ^
1 error generated.
ninja: build stopped: subcommand failed.
gn desc out/Default v8:run_mksnapshot_default args > out/Default/default_mksnapshot_args
Probably needs to be |
This code is being merged to a branch before the change from crrev.com/c/5010979
2 test failures on the WoA build:
These seem unrelated and likely flakes. Happy to rerun, but the important tests for this change did pass so I'm leaning towards dismissing the two failures as flakes. |
Release Notes Persisted
|
Backport of #40892
See that PR for details.
Notes: Fixed default protocol handler behavior on Windows.