Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure an AXContext before painting #40981

Merged
merged 2 commits into from Jan 17, 2024
Merged

fix: ensure an AXContext before painting #40981

merged 2 commits into from Jan 17, 2024

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 12, 2024 •
edited

Description of Change

Closes #40748
Refs CL:5165954

Before this CL, if a node was highlighted in an iframe, an AXContext
may not have been initialized before painting began, which is a
rendering lifecycle error. Fixed: 1515088

Already present in 29 & main.

Checklist

Release Notes

Notes: Fixed a potential renderer crash when inspecting elements.

@codebytere codebytere added backport This is a backport PR backport-check-skip Skip trop's backport validity checking 28-x-y labels Jan 12, 2024
@codebytere codebytere requested a review from a team January 12, 2024 15:14
@codebytere codebytere requested a review from a team as a code owner January 12, 2024 15:14
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Jan 15, 2024
@codebytere codebytere linked an issue Jan 15, 2024 that may be closed by this pull request
[Bug]: Renderer crash when inspecting element #40748
Closed
3 tasks
@codebytere codebytere merged commit 4583072 into 28-x-y Jan 17, 2024
13 checks passed
@codebytere codebytere deleted the fix-ensure-axcontext branch January 17, 2024 17:15
@release-clerk Release Clerk
Copy link

release-clerk bot commented Jan 17, 2024

Release Notes Persisted

Fixed a potential renderer crash when inspecting elements.

@codebytere codebytere mentioned this pull request Jan 17, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
28-x-y backport This is a backport PR backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Renderer crash when inspecting element
2 participants
@codebytere @ckerr