fix: use HasStyleMask(NSWindowStyleMaskResizable) instead of IsResizable() for enabling/disabling window maximize button
#41027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
…izable()` for enabling/disabling window maximize button Co-authored-by: Tamás Zahola <tzahola@gmail.com>
5 tasks
trop
bot
added
27-x-y
backport
miniak
approved these changes
Jan 17, 2024
ckerr
approved these changes
Jan 22, 2024
|
Failing tests are unrelated, merging. |
deepak1556
deleted the
trop/27-x-y-bp-fix-use-hasstylemask-nswindowstylemaskresizable-instead-of-isresizable-for-enabling-disabling-window-maximize-button-1705512239454
branch
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #40994
See that PR for details.
Notes: fix macOS bug that causes window maximize button to be disabled in full-screen mode