Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly stream uploadData in protocol.handle() #41052

Merged
merged 6 commits into from Feb 16, 2024
Merged

fix: properly stream uploadData in protocol.handle() #41052

merged 6 commits into from Feb 16, 2024

Commits on Feb 14, 2024

  1. refactor(protocol): extract file stream factory 

    Increase readability by moving the file stream creation logic out of the
`uploadData` to request body conversion function.
    @BurningEnlightenment
    BurningEnlightenment committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0707eb5 View commit details
    Browse the repository at this point in the history

  2. fix: properly flatten streams in protocol.handle() 

    Refs: electron#39658
    @BurningEnlightenment
    BurningEnlightenment committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    e98785a View commit details
    Browse the repository at this point in the history

  3. fix: protocol.handle() filter null origin header 

    Refs: electron#40754
    @BurningEnlightenment
    BurningEnlightenment committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    03d5b66 View commit details
    Browse the repository at this point in the history

  4. fix: remove obsolete TODO comment 

    Refs: electron#38929
    @BurningEnlightenment
    BurningEnlightenment committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    5e9af2c View commit details
    Browse the repository at this point in the history

  5. fix: forward Blob parts in protocol.handle() 

    Refs: electron#40826
    @BurningEnlightenment
    BurningEnlightenment committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ce67224 View commit details
    Browse the repository at this point in the history

  6. fix: explicitly error out on unknown chunk parts

    @BurningEnlightenment
    BurningEnlightenment committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    885ae8c View commit details
    Browse the repository at this point in the history