revert: replace BrowserView with WebContentsView #41060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bd304f7.
VerteDinde
added
backport-check-skip
clavin
approved these changes
Jan 19, 2024
dsanders11
changed the title
codebytere
approved these changes
Jan 20, 2024
|
Release Notes Persisted
|
mlaurencin
added a commit
that referenced
this pull request
Feb 16, 2024
Since #41060 reverted the WebContentsView changes for 29-x-y, the breaking changes doc should have it noted as changing in v30 and not v29.
mlaurencin
added a commit
that referenced
this pull request
Feb 16, 2024
Since #41060 reverted the WebContentsView changes for 29-x-y, the breaking changes doc should have it noted as changing in v30 and not v29. Notes: None
mlaurencin
added a commit
that referenced
this pull request
Feb 16, 2024
Since #41060 reverted the WebContentsView changes for 29-x-y, the breaking changes doc should have it noted as changing in v30 and not v29. Notes: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Reverts #40759 after a few issues were reported - this revert will happen prior to the Electron 29 beta, to give us time to resolve the issues reported.
Checklist
npm testpassesRelease Notes
Notes: Reverted new WebContentsView and BaseWindow APIs.