fix: only remove hijackable envs from foreign parent #41079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
added
semver/patch
deepak1556
approved these changes
Jan 23, 2024
ckerr
approved these changes
Jan 23, 2024
codebytere
approved these changes
Jan 23, 2024
|
Release Notes Persisted
|
|
I have automatically backported this PR to "26-x-y", please check out #41099 |
trop
bot
added
in-flight/26-x-y
and removed
target/26-x-y
|
I have automatically backported this PR to "27-x-y", please check out #41100 |
trop
bot
added
in-flight/27-x-y
and removed
target/27-x-y
|
I have automatically backported this PR to "28-x-y", please check out #41101 |
|
I have automatically backported this PR to "29-x-y", please check out #41102 |
trop
bot
added
in-flight/29-x-y
and removed
target/28-x-y
Closed
3 tasks
trop
bot
added
merged/29-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#40770 took an aggressive way to disable all envs starting with
NODE_when process is started from a foreign parent, but it appears that at least a portion of apps are running into issues when usingforklegally #40987.This PR takes a simpler approach by only disabling the
NODE_OPTIONSandNODE_REPL_EXTERNAL_MODULEto fix node IPC, I'll try to locate the root issue and figure out a better approach in following PRs.Checklist
npm testpassesRelease Notes
Notes: Fix forked child process not able to send IPC message under some cases on macOS.