fix: dangling raw_ptr in OSRWHV destructor #41088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`delegated_frame_host_` holds a pointer to `delegated_frame_host_client_`. Since `delegated_frame_host_client_` was being destroyed first, that pointer was dangling in the OSRWHV destructor. Also, make these two unique_ptr fields `const` since they point to the same objects for the lifespan of the OSRWHV.
ckerr
added
semver/patch
deepak1556
reviewed
Jan 24, 2024
Comment on lines
250
to
251
| compositor_.reset(); | ||
| root_layer_.reset(); |
There was a problem hiding this comment.
Do these two calls need to be explicit in the destructor ?
There was a problem hiding this comment.
@deepak1556 good catch, I was going to remove them for that reason: you're right, they're entirely redundant.
I decided to leave them alone here because it's a little off-topic for this bugfix PR, and I have another cleanup PR in mind where it's a better fit.
deepak1556
approved these changes
Jan 25, 2024
zcbenz
approved these changes
Jan 25, 2024
|
No Release Notes |
This was referenced Jan 25, 2024
|
I have automatically backported this PR to "28-x-y", please check out #41116 |
trop
bot
added
in-flight/28-x-y
and removed
target/28-x-y
|
I have automatically backported this PR to "29-x-y", please check out #41117 |
trop
bot
added
in-flight/29-x-y
merged/28-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
delegated_frame_host_holds a pointer todelegated_frame_host_client_. Sincedelegated_frame_host_client_was being destroyed first, that pointer was dangling in the OSRWHV destructor.Also, make these two unique_ptr fields
constsince they point to the same objects for the lifespan of the OSRWHV.Checklist
npm testpassesRelease Notes
Notes: none