Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: select-usb-device should respect filters option #41166

Merged
merged 1 commit into from Jan 31, 2024
Merged

fix: select-usb-device should respect filters option #41166

merged 1 commit into from Jan 31, 2024

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 30, 2024 •
edited

Description of Change

Closes #39279.

Fixes an issue where select-usb-device did not respect the filter option in navigator.usb.requestDevice(). This is respected in Chromium using this logic which was missing in our own. To fix this, remove filtered items from the vector prior to creating the v8::Object to emit in the event.

Checklist

Release Notes

Notes: Fixed an issue where select-usb-device did not respect the filter option in navigator.usb.requestDevice().

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 30, 2024
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. and removed new-pr 🌱 PR opened in the last 24 hours labels Jan 30, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 30, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 31, 2024
@jkleinsc jkleinsc merged commit e4d5dc1 into main Jan 31, 2024
30 checks passed
@jkleinsc jkleinsc deleted the usb-device-filter branch January 31, 2024 14:53
@release-clerk Release Clerk
Copy link

release-clerk bot commented Jan 31, 2024

Release Notes Persisted

Fixed an issue where select-usb-device did not respect the filter option in navigator.usb.requestDevice().

@trop trop bot mentioned this pull request Jan 31, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Jan 31, 2024

I have automatically backported this PR to "27-x-y", please check out #41196

@trop trop bot mentioned this pull request Jan 31, 2024
Merged
@trop trop bot removed the target/27-x-y PR should also be added to the "27-x-y" branch. label Jan 31, 2024
@trop trop bot mentioned this pull request Jan 31, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Jan 31, 2024

I have automatically backported this PR to "29-x-y", please check out #41197

@trop
Copy link
Contributor

trop bot commented Jan 31, 2024

I have automatically backported this PR to "28-x-y", please check out #41198

@trop trop bot added in-flight/29-x-y in-flight/28-x-y merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. in-flight/27-x-y labels Jan 31, 2024
@trop trop bot added merged/29-x-y PR was merged to the "29-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. and removed in-flight/29-x-y in-flight/28-x-y labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@ckerr ckerr Awaiting requested review from ckerr

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Filters for USB requestDevice
2 participants
@codebytere @jkleinsc