Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure invalid URL loads promises are fulfilled. #41194

Merged
merged 2 commits into from Feb 5, 2024
Merged

fix: make sure invalid URL loads promises are fulfilled. #41194

merged 2 commits into from Feb 5, 2024

Conversation

marekharanczyk
Copy link
Contributor

@marekharanczyk marekharanczyk commented Jan 31, 2024 •
edited

Description of Change

Invalid URLs never start navigation so there will be no navigation finish and did-fail-load will be only event raised in such cases. Fulfill the loadURL promise in did-fail-load if navigation was not started.

This change fixes #41193.

Checklist

Release Notes

Notes: Properly reject webcontents.loadURL promise on invalid URL load.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 31, 2024
@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. labels Feb 1, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 1, 2024
@zcbenz zcbenz merged commit 398ca2a into electron:main Feb 5, 2024
25 checks passed
@release-clerk Release Clerk
Copy link

release-clerk bot commented Feb 5, 2024

Release Notes Persisted

Properly reject webcontents.loadURL promise on invalid URL load.

@trop
Copy link
Contributor

trop bot commented Feb 5, 2024

I was unable to backport this PR to "27-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Feb 5, 2024

I was unable to backport this PR to "28-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Feb 5, 2024

I was unable to backport this PR to "29-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/27-x-y needs-manual-bp/28-x-y needs-manual-bp/29-x-y and removed target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
needs-manual-bp/28-x-y needs-manual-bp/29-x-y semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Unfulfilled loadURL promise on invalid URL load.
5 participants
@marekharanczyk @ckerr @zcbenz @deepak1556 @jkleinsc