Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: original-fs import replacement #41209

Merged
merged 1 commit into from Feb 5, 2024
Merged

fix: original-fs import replacement #41209

merged 1 commit into from Feb 5, 2024

Conversation

codebytere
Copy link
Member

Description of Change

Closes #41008.
Refs #40545.

Fixes an issue where original-fs methods were not properly corrected for patched imports. This broke in #40545 but wasn't exposed until ac031bf. Fix this by correctly swapping out require('fs/*') calls in original-fs with require('original-fs/*').

Checklist

Release Notes

Notes: Fixes an issue where original-fs methods were not properly corrected for patched imports.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/29-x-y PR should also be added to the "29-x-y" branch. labels Feb 1, 2024
@codebytere codebytere requested a review from a team as a code owner February 1, 2024 11:29
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 1, 2024
@codebytere codebytere added the target/28-x-y PR should also be added to the "28-x-y" branch. label Feb 1, 2024
dsanders11
dsanders11 approved these changes Feb 1, 2024
View reviewed changes
spec/asar-spec.ts Show resolved Hide resolved
@VerteDinde
Copy link
Member

I think the Linux tests are failing on the nut.js import - a rebase against main should fix it

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 2, 2024
@codebytere
Copy link
Member Author

reporting api sends a report for an intervention

is unrelated and flaky.

@codebytere codebytere merged commit 5dfa9e3 into main Feb 5, 2024
15 of 16 checks passed
@codebytere codebytere deleted the fix-original-fs-imports branch February 5, 2024 08:51
@release-clerk Release Clerk
Copy link

release-clerk bot commented Feb 5, 2024

Release Notes Persisted

Fixes an issue where original-fs methods were not properly corrected for patched imports.

@trop
Copy link
Contributor

trop bot commented Feb 5, 2024

I was unable to backport this PR to "28-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/28-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. labels Feb 5, 2024
@trop trop bot mentioned this pull request Feb 5, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Feb 5, 2024

I have automatically backported this PR to "29-x-y", please check out #41238

@trop trop bot added in-flight/29-x-y merged/29-x-y PR was merged to the "29-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. in-flight/29-x-y labels Feb 5, 2024
@codebytere codebytere mentioned this pull request Feb 6, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/29-x-y PR was merged to the "29-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: original-fs does not provide unmodified methods
4 participants
@codebytere @VerteDinde @zcbenz @dsanders11