fix: crash on macOS non-programmatic close #41264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
requested review from
zcbenz,
deepak1556,
VerteDinde and
MarshallOfSound
VerteDinde
approved these changes
Feb 7, 2024
ckerr
approved these changes
Feb 7, 2024
deepak1556
approved these changes
Feb 7, 2024
zcbenz
approved these changes
Feb 8, 2024
|
Unrelated WOA failures due to occlusion tests. |
|
Release Notes Persisted
|
This was referenced Feb 9, 2024
|
I have automatically backported this PR to "28-x-y", please check out #41298 |
trop
bot
added
in-flight/28-x-y
and removed
target/28-x-y
|
I have automatically backported this PR to "29-x-y", please check out #41299 |
trop
bot
added
in-flight/29-x-y
merged/28-x-y
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #40798
Refs microsoft/vscode#204563
Fixes a crash that started occurring sporadically with some types of macOS window close after
PartitionAllocwas enabled upstream. It seems to be the case now thatperformClose:can causewindow_to be null, thus causing the call toIsVisibleto crash trying to access a deallocated instance. There's probably more effective long-term fix here but we can fix this by moving the conditional determining whether we should callNotifyWindowCloseButtonClicked()for a closed sheet aboveperformClosureto avoid this problem altogether.Using the
Cmd+Tab -> Cmd+Qrepro provided in #40798 I tracked this back to v28.0.0-alpha.3...v28.0.0-alpha.4 - specifically reverting #33981 fixes the issue as well so we should investigate that further as a follow up.h/t @MarshallOfSound for speculating this fix in response to what might be the same issue in Discord.
cc @deepak1556 @bpasero
Checklist
npm testpassesRelease Notes
Notes: Fixed a crash that started occurring sporadically with some types of macOS window close